Re: DFRefactor and Structs
I'll add it to the same thread as it's the same pass of DFRefactor, but another odd effect. You can have the sources if you need them
[code]
Procedure End_of_Process
Integer iRepairType, iHour, iMinute, iStaffCode, iWatchGender, iJobAssignment, iTicketNo
Integer iWatchBandType, iWatchColour, iWatchCrystal, iWatchCase, iQty, iWatchMovementType
Integer iWatchCrown, iWatchWaterProof, iWatchBandCondition, iWatchServiceType, iAssignedStaffNo, iPriority
DateTime dtCurrentDateTime
String sTime, sStaffNo, sName, sAssignedStaffName, sPrevTicketNo, sShip, sTermID sPathTag
String sEmail, sAddress1, sAddress2, sCity, sRegion, sPostCodeZip, sCountryCode
String sFax, sItemDesc, sBrand, sModel sWatchSN, sRcvStaffName, sBarCodeNotes, sWatchColourOtherDesc
String sRequestedRepair, sNotes, sJobNotes, sBezelType, sDialType, sStatusCode, sStatusDesc
Number nCustNo, nItemVal, nEstCost, nDepUS, nDepCI
Boolean bNewCustomer, bUnderWarranty, bReturnRepair, bWatchIsWorking, bOneHourJob
Integer iPh1CountryCode iPh1AreaCode iPhoneNo iPh2CountryCode iPh2AreaCode iContactNo
Date dPromisedDate
String sJewelrySerial sJewelryGroup sJewelryMetalType sJewelryPriStone sJewelrySecStone
String sJewelryOthStone sJewelryCondOtherDesc sJewelryReqRprResizeFrom
String sJewelryReqRprResizeTo sJewelryReqRprOtherDesc
Boolean bJewelryCondMissingStone bJewelryCondChips bJewelryCondDents
Boolean bJewelryCondCracks bJewelryCondKinks bJewelryCondOther
Boolean bJewelryReqRprSoldering bJewelryReqRprStoneReplacement bJewelryReqRprProngs
Boolean bJewelryReqRprKnotted bJewelryReqRprOther
String sOtherLine sOtherGroup sOtherItemOtherDesc sOtherItemCondition sOtherRequestedRepair
[/code]
becomes
[code]
Procedure End_of_Process
Integer iTicketNo
Integer iWatchMovementType
Integer iPriority
DateTime dtCurrentDateTime
String sTime, sTermID sPathTag
String sCountryCode
String sModel sWatchColourOtherDesc
String sStatusDesc
Number nDepCI
Boolean bOneHourJob
Integer iPh1CountryCode iPh1AreaCode iPhoneNo iPh2CountryCode iPh2AreaCode iContactNo
Date dPromisedDate
String sJewelrySerial sJewelryGroup sJewelryMetalType sJewelryPriStone sJewelrySecStone
String sJewelryOthStone sJewelryCondOtherDesc sJewelryReqRprResizeFrom
String sJewelryReqRprResizeTo sJewelryReqRprOtherDesc
Boolean bJewelryCondMissingStone bJewelryCondChips bJewelryCondDents
Boolean bJewelryCondCracks bJewelryCondKinks bJewelryCondOther
Boolean bJewelryReqRprSoldering bJewelryReqRprStoneReplacement bJewelryReqRprProngs
Boolean bJewelryReqRprKnotted bJewelryReqRprOther
String sOtherLine sOtherGroup sOtherItemOtherDesc sOtherItemCondition sOtherRequestedRepair
[/code]
Is it the commas? Just noticed them...
Re: DFRefactor and Structs
Yep - it's the commas. 19.1 does not like them - though 19.0 & earlier ignored them.
Re: DFRefactor and Structs
[QUOTE=Garret Mott;351721]Yep - it's the commas. 19.1 does not like them - though 19.0 & earlier ignored them.[/QUOTE]
they don't bother 19.1 compiler or runtime at all... at least in the few example I've found.
Re: DFRefactor and Structs
Dave,
re. struct. I'm pretty sure this was reported earlier, but I cannot locate it in the bug tracker, so logged it.
[url]https://projects.vdf-guidance.com/issues/169[/url]
As you guessed.. it is because you are declaring a struct within a method.
Not sure if we should even want to fix that, but at least it is logged now.
re. refactoring methods for Insert and Replace to functions.
Sure you can email it to me.
Can't promise that I can massage it to merge with DfRefactor, but I will give it a try.
--
Wil
Re: DFRefactor and Structs
Yes, it is the comma's.
They have other problems (the debugger doesn't like them either IIRC)
See:
[url]https://projects.vdf-guidance.com/issues/159[/url]
--
Wil