PDA

View Full Version : Language Cleanups for DF Packages



Frank Cheng
12-Jul-2018, 02:58 PM
See this thread

https://support.dataaccess.com/Forums/showthread.php?57146-Double-Augmentation

The duplicate methods are still there as of DF 19.1 Alpha 3.

Also the "incorrect" use of "Until"

DataDict.pkg Line:3546 UNTIL
DataDict.pkg Line:3568 UNTIL
DataDict.pkg Line:3571 UNTIL
DataDict.pkg Line:4003 UNTIL
DataDict.pkg Line:4255 UNTIL
DataDict.pkg Line:4291 UNTIL
cCrystal.pkg Line:243 UNTIL
cCrystal.pkg Line:1258 UNTIL
DFdtCent.pkg Line:169 UNTIL
Table_ds.pkg Line:268 UNTIL
DFEnRad.pkg Line:336 UNTIL

The weird use of Case Begin without Case Break

cClientWebService.pkg Line:1380
cClientWebService.pkg Line:1390
GENDDF.PKG Line: 717
GENDDF.PKG Line: 720
GENDDF.PKG Line: 722
GENDDF.PKG Line: 725
GENDDF.PKG Line: 730
GENDDF.PKG Line: 939
GENDDF.PKG Line: 946
GENDDF.PKG Line: 953
GENDDF.PKG Line: 960
GENDDF.PKG Line: 967
GENDDF.PKG Line: 983
GENDDF.PKG Line: 990
GENDDF.PKG Line: 995

Frank Cheng

starzen
12-Jul-2018, 04:04 PM
added a few more checks and there is a nice one in cursor.pkg


Class CursorShape is a DFBaseToolPanel //BasicPanel

Procedure Construct_Object
Property Handle ClassCursorHandle 0
Set Visible_State to False
Set Size to 1 1
End_Procedure



no forward send in the constructor

Frank Cheng
13-Jul-2018, 12:20 AM
Implicit global variables

Winuser.pkg line: 4 EXTKEY
DataDict.pkg line: 95 DD_Global_Validation_Prompt_Object
DataDict.pkg line: 99 DD_Current_Mark_Id
Windows.pkg line: 778 Default_Form_Floating_Menu_ID
Windows.pkg line: 1263 DEFAULT_LABEL_OFFSET
Windows.pkg line: 1266 DEFAULT_LABEL_JMODE
Windows.pkg line: 2536 gbKenterNext
Windows.pkg line: 2889 Default_Currency_Mask
Windows.pkg line: 2889 Default_Numeric_Mask
Windows.pkg line: 2889 Default_Date_Mask
Windows.pkg line: 2890 Default_Date_Window
seq_chnl.pkg line: 45 Seq$Channel$Error$Mode
cli.pkg line: 921 CLI$StrDummy
cli.pkg line: 922 CLI$IntDummy
sql.pkg line: 52 SQLResult
sql.pkg line: 114 giLastSQLhdbc
sql.pkg line: 115 giLastSQLhstmt
cBasicReport.pkg line: 36 System_default_pageend
cBasicReport.pkg line: 37 System_default_pagefeed
DFDEOft.pkg line: 71 Default_dbFloating_Menu_ID
cCrystal.pkg line: 20 ghoCrystalReportServer
Dftimer.pkg line: 160 giTimerManager
CrystalReport.pkg line: 77 WinQL_Report_Initialized
DFRpt.pkg line: 38 System_default_pageend
DFRpt.pkg line: 39 System_default_pagefeed
GENDDF.PKG line: 94 giX$File
GENDDF.PKG line: 95 giX$Field
GENDDF.PKG line: 96 giX$Index
GENDDF.PKG line: 97 gbMakeInt
GENDDF.PKG line: 98 ghIntChannel
sqlold.pkg line: 27 _embsqlghoSQLHandleMngr
sqlold.pkg line: 30 SQLResult

Frank Cheng

Frank Cheng
17-Jul-2018, 02:58 PM
There are some procedure_return/function_return end_procedure/end_function mismatches in the DF packages. Should be pretty harmless to fix.

DDValtbl.pkg(153) : END_FUNCTION
DDValtbl.pkg(162) : END_FUNCTION
DDValtbl.pkg(290) : END_FUNCTION
DDValtbl.pkg(302) : END_FUNCTION
DataDict.pkg(2173) : END_FUNCTION
DataDict.pkg(2195) : END_FUNCTION
DataDict.pkg(3379) : Function_Return
DataDict.pkg(3546) : UNTIL
DataDict.pkg(3568) : UNTIL
DataDict.pkg(3571) : UNTIL
DataDict.pkg(4003) : UNTIL
DataDict.pkg(4255) : UNTIL
DataDict.pkg(4291) : UNTIL
DataDict.pkg(4974) : END_PROCEDURE
DataDict.pkg(4999) : END_PROCEDURE
DataDict.pkg(5535) : END_PROCEDURE
DataDict.pkg(6792) : END_FUNCTION
gFormatNumbers.pkg(42) : END_FUNCTION
gFormatNumbers.pkg(46) : END_FUNCTION
Windows.pkg(2597) : Function_Return
Dftab_mx.pkg(686) : Procedure_Return
Dftab_mx.pkg(853) : END_PROCEDURE
Dftab_mx.pkg(871) : END_PROCEDURE
Windows.pkg(6240) : Function_Return
Windows.pkg(6254) : Function_Return
combo_mx.pkg(126) : END_PROCEDURE
combo_mx.pkg(443) : END_PROCEDURE
seq_chnl.pkg(55) : END_PROCEDURE
seq_chnl.pkg(111) : END_PROCEDURE
cConnection.pkg(719) : END_PROCEDURE
cDistributedBusinessProcess.pkg(158) : END_PROCEDURE
cDistributedBusinessProcess.pkg(168) : END_PROCEDURE
Variant.pkg(57) : END_PROCEDURE
cVdfInternetSession.pkg(596) : END_PROCEDURE
cVdfInternetSession.pkg(620) : END_PROCEDURE
cVdfInternetSession.pkg(643) : END_PROCEDURE
Flexml.pkg(832) : END_PROCEDURE
Flexml.pkg(1860) : Function_Return
cInternetSessionBusinessProcess.pkg(568) : Function_Return
cInternetSessionBusinessProcess.pkg(569) : END_FUNCTION
cInternetSessionBusinessProcess.pkg(648) : END_FUNCTION
cBaseWebApp.pkg(637) : END_PROCEDURE
cWebPropertyManager.pkg(70) : Procedure_Return
cWebPropertyManager.pkg(78) : Procedure_Return
cWebPropertyManager.pkg(85) : Procedure_Return
cWebView.pkg(1131) : END_FUNCTION
cWebView.pkg(2081) : END_PROCEDURE
cWebView.pkg(2097) : END_PROCEDURE
cWebSlider.pkg(135) : END_FUNCTION
cWebSlider.pkg(151) : END_FUNCTION
cWebViewStack.pkg(139) : END_PROCEDURE
cWebViewStack.pkg(347) : END_PROCEDURE
cWebViewStack.pkg(394) : END_PROCEDURE
Batchdd.pkg(281) : END_FUNCTION
cCJCommandBarSystem.pkg(1328) : END_PROCEDURE
cCJCommandBarSystem.pkg(1341) : END_PROCEDURE
cCJCommandBarSystem.pkg(2135) : END_FUNCTION
cCJCommandBarSystem.pkg(2148) : END_FUNCTION
cCJCommandBarSystem.pkg(2161) : END_FUNCTION
cCJCommandBarSystem.pkg(2174) : END_FUNCTION
cCJCommandBarSystem.pkg(2187) : END_FUNCTION
cCJCommandBarSystem.pkg(2201) : END_FUNCTION
cCJCommandBarSystem.pkg(2528) : END_FUNCTION
cCJGridSortHandler.pkg(147) : END_PROCEDURE
cCJGridDataSource.pkg(119) : END_PROCEDURE
cCJGridSearchDialog.pkg(164) : END_PROCEDURE
cCJGrid.pkg(2495) : END_PROCEDURE
cCJGrid.pkg(3971) : Function_Return
cCJGrid.pkg(3977) : Function_Return
cCJGrid.pkg(4643) : END_PROCEDURE
cCJGrid.pkg(5549) : END_PROCEDURE
cCJGrid.pkg(6190) : END_PROCEDURE
cCJGrid.pkg(6234) : END_PROCEDURE
cCJGrid.pkg(6855) : Function_Return
cCJGridPromptList.pkg(253) : END_FUNCTION
DFAStBar.pkg(56) : END_PROCEDURE
DFADlg.pkg(137) : Function_Return
cXmlHttpTransfer.pkg(459) : END_PROCEDURE
cXmlHttpTransfer.pkg(474) : END_PROCEDURE
cXmlHttpTransfer.pkg(619) : END_PROCEDURE
cXmlHttpTransfer.pkg(630) : END_PROCEDURE
cClientWebService.pkg(1380) : CASE BEGIN??
cClientWebService.pkg(1390) : CASE BEGIN??
cClientWebService.pkg(1946) : END_PROCEDURE
cClientWebService12.pkg(183) : END_PROCEDURE
DD_Deomx.pkg(708) : Procedure_Return
DD_Deomx.pkg(1376) : END_FUNCTION
DD_Deomx.pkg(1402) : END_FUNCTION
DD_Deomx.pkg(1696) : Procedure_Return
DD_Deomx.pkg(1752) : Procedure_Return
DD_Deomx.pkg(1948) : Function_Return
cComDbActiveXControl.pkg(205) : END_PROCEDURE
cComDbActiveXControl.pkg(215) : END_PROCEDURE
cComDbActiveXControl.pkg(225) : END_PROCEDURE
cComDbActiveXControl.pkg(274) : END_PROCEDURE
cComDbActiveXControl.pkg(326) : Function_Return
cComDbActiveXControl.pkg(334) : Function_Return
cComDbActiveXControl.pkg(448) : Function_Return
cCrystal.pkg(243) : UNTIL
cCrystal.pkg(1258) : UNTIL
cDbCJGridDataSource.pkg(1142) : END_PROCEDURE
cdbCJGridColumn.pkg(109) : Function_Return
cdbCJGridColumn.pkg(633) : END_PROCEDURE
cdbCJGridColumn.pkg(756) : END_FUNCTION
cDbCJGrid.pkg(143) : END_PROCEDURE
cDbCJGrid.pkg(1069) : END_PROCEDURE
cJsonHttpTransfer.pkg(236) : END_PROCEDURE
cLinkLabel.pkg(140) : Procedure_Return
codecsl.pkg(225) : Procedure_Return
codecsl.pkg(226) : END_PROCEDURE
codepick.pkg(165) : Procedure_Return
codepick.pkg(166) : END_PROCEDURE
cRowIdArray.pkg(30) : END_PROCEDURE
cStatusbar.pkg(455) : END_PROCEDURE
cWinReport2.pkg(515) : END_PROCEDURE
Datalist.pkg(980) : Function_Return
DfBitmap.pkg(124) : END_PROCEDURE
dfentry.pkg(119) : Function_Return
DFdtCent.pkg(169) : UNTIL
DD_Cmbmx.pkg(232) : Function_Return
MSSqldrv.pkg(173) : END_PROCEDURE
Table_ds.pkg(268) : UNTIL
Table_ds.pkg(430) : Procedure_Return
Table_ds.pkg(471) : Procedure_Return
Table_ds.pkg(472) : END_PROCEDURE
DFTable.pkg(548) : END_FUNCTION
DFSellst.pkg(313) : END_PROCEDURE
DfddPkLt.pkg(149) : END_PROCEDURE
DFEnRad.pkg(336) : UNTIL
DFEnRad.pkg(665) : END_PROCEDURE
DFEnRad.pkg(675) : END_PROCEDURE
DFEnRad.pkg(685) : END_PROCEDURE
FlexCom.pkg(1052) : END_PROCEDURE
FlexComWA.pkg(1017) : END_PROCEDURE
GENDDF.PKG(717) : CASE BEGIN??
GENDDF.PKG(720) : CASE BEGIN??
GENDDF.PKG(722) : CASE BEGIN??
GENDDF.PKG(725) : CASE BEGIN??
GENDDF.PKG(730) : CASE BEGIN??
GENDDF.PKG(939) : CASE BEGIN??
GENDDF.PKG(946) : CASE BEGIN??
GENDDF.PKG(953) : CASE BEGIN??
GENDDF.PKG(960) : CASE BEGIN??
GENDDF.PKG(967) : CASE BEGIN??
GENDDF.PKG(983) : CASE BEGIN??
GENDDF.PKG(990) : CASE BEGIN??
GENDDF.PKG(995) : CASE BEGIN??
GENDDF.PKG(1087) : Function_Return

Frank Cheng