PDA

View Full Version : A few lines to clean up possibly



starzen
26-Jun-2018, 09:29 AM
While they technically compile i would think these could use a space between the End_Function and the comment



End_Function// BrowseConnect


there are a few in mssqldrv.pkg

also in report.pkg again technically it compiles but probably an error waiting to happen in the following code



Function Handle_KeyPressed Returns Integer
Integer Rpt_Status
If (Child_Rpt_State(Self)) ;
// Delegate Get Handle_KeyPressed to Rpt_Status
Get Handle_KeyPressed of (Main_Report_Id(Self)) to Rpt_Status
Else Begin // once here we are always at the outermost
Get Test_KeyPressed to Rpt_Status // report..the ultimate parent
If (Rpt_Status <> 0) Begin
Set Cancelled_State to True
Function_Return RPT_CANCEL
End
End
Function_Return Rpt_Status
End_Function


the if (Child_Rpt_State(Self)) with the semicolon and then a comment on a separate line followed by an else